Messages in this thread | | | Date | Wed, 17 Jun 2015 13:14:12 +0200 | From | Christoph Hellwig <> | Subject | Re: [PATCH v4 1/6] arch: unify ioremap prototypes and macro aliases |
| |
On Thu, Jun 11, 2015 at 05:19:18PM -0400, Dan Williams wrote: > Some archs define the first parameter to ioremap() as unsigned long, > while the balance define it as resource_size_t. Unify on > resource_size_t to enable passing ioremap function pointers. Also, some > archs use function-like macros for defining ioremap aliases, but > asm-generic/iomap.h expects object-like macros, unify on the latter.
Not urgent: but maybe this is a big hint that we should not define the prototypes on a per-architecture basis but in a common header file.
| |