lkml.org 
[lkml]   [2015]   [Jun]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v4 3/3] net/xen-netback: Don't mix hexa and decimal with 0x in the printf format
    Hello.

    On 06/16/2015 10:10 PM, Julien Grall wrote:

    > Append 0x to all %x in order to avoid while reading when there is other
    > decimal value in the log.

    > Also replace some of the hexadecimal print to decimal to uniformize the
    > format with netfront.

    > Signed-off-by: Julien Grall <julien.grall@citrix.com>
    > Cc: Wei Liu <wei.liu2@citrix.com>
    > Cc: Ian Campbell <ian.campbell@citrix.com>
    > Cc: netdev@vger.kernel.org

    > ---
    > Changes in v4:
    > - Patch added
    > ---
    > drivers/net/xen-netback/netback.c | 14 +++++++-------
    > 1 file changed, 7 insertions(+), 7 deletions(-)

    > diff --git a/drivers/net/xen-netback/netback.c b/drivers/net/xen-netback/netback.c
    > index ba3ae30..11bd9d8 100644
    > --- a/drivers/net/xen-netback/netback.c
    > +++ b/drivers/net/xen-netback/netback.c
    [...]
    > @@ -874,7 +874,7 @@ static inline void xenvif_grant_handle_set(struct xenvif_queue *queue,
    > if (unlikely(queue->grant_tx_handle[pending_idx] !=
    > NETBACK_INVALID_HANDLE)) {
    > netdev_err(queue->vif->dev,
    > - "Trying to overwrite active handle! pending_idx: %x\n",
    > + "Trying to overwrite active handle! pending_idx: 0x%x\n",

    Using "%#x" is shorter ind does the same.

    > pending_idx);
    > BUG();
    > }
    > @@ -887,7 +887,7 @@ static inline void xenvif_grant_handle_reset(struct xenvif_queue *queue,
    > if (unlikely(queue->grant_tx_handle[pending_idx] ==
    > NETBACK_INVALID_HANDLE)) {
    > netdev_err(queue->vif->dev,
    > - "Trying to unmap invalid handle! pending_idx: %x\n",
    > + "Trying to unmap invalid handle! pending_idx: 0x%x\n",

    Same here.

    [...]
    > @@ -1731,7 +1731,7 @@ void xenvif_idx_unmap(struct xenvif_queue *queue, u16 pending_idx)
    > &queue->mmap_pages[pending_idx], 1);
    > if (ret) {
    > netdev_err(queue->vif->dev,
    > - "Unmap fail: ret: %d pending_idx: %d host_addr: %llx handle: %x status: %d\n",
    > + "Unmap fail: ret: %d pending_idx: %d host_addr: %llx handle: 0x%x status: %d\n",

    And here.

    [...]

    WBR, Sergei



    \
     
     \ /
      Last update: 2015-06-16 22:21    [W:4.097 / U:0.052 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site