Messages in this thread | | | Date | Mon, 15 Jun 2015 10:58:52 +0200 | From | Borislav Petkov <> | Subject | Re: [PATCH 1/3] x86, acpi: Eliminate saved_eip |
| |
On Sun, Jun 14, 2015 at 03:23:08PM +0200, Denys Vlasenko wrote: > It always contains the address of "ret_point" label
This commit message is very laconic - I had to go look at the code just to see what you mean. I guess it should be something like:
"Get rid of the global variable saved_eip as it is only written to and jump directly to ret_point instead. No functionality change."
Other than that, patch looks ok.
> Run-tested. > > Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com> > CC: Pavel Machek <pavel@ucw.cz> > CC: Linus Torvalds <torvalds@linux-foundation.org> > CC: Steven Rostedt <rostedt@goodmis.org> > CC: Ingo Molnar <mingo@kernel.org> > CC: Borislav Petkov <bp@alien8.de> > CC: "H. Peter Anvin" <hpa@zytor.com> > CC: Andy Lutomirski <luto@amacapital.net> > CC: Oleg Nesterov <oleg@redhat.com> > CC: Frederic Weisbecker <fweisbec@gmail.com> > CC: Alexei Starovoitov <ast@plumgrid.com> > CC: Will Drewry <wad@chromium.org> > CC: Kees Cook <keescook@chromium.org> > CC: x86@kernel.org > CC: linux-kernel@vger.kernel.org > --- > arch/x86/kernel/acpi/wakeup_32.S | 10 +--------- > 1 file changed, 1 insertion(+), 9 deletions(-)
Reviewed-by: Borislav Petkov <bp@suse.de>
-- Regards/Gruss, Boris.
ECO tip #101: Trim your mails when you reply. --
| |