lkml.org 
[lkml]   [2015]   [Jun]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/1] pcmcia: Fix resource leaks in yenta_probe() and _close()
On Mon, Jun 15, 2015 at 02:43:59AM +0900, Takeshi Yoshimura wrote:
> There are some resource leaks in yenta_probe() and _close(). I fixed
> the following issues with some code cleanups. Thanks to Dominik's
> suggestions.
>
> On the error path in yenta_probe():
> - a requested irq is not released
> - yenta_free_resources() and pci_set_drvdata(dev, NULL) are not called
>
> In yenta_close():
> - kfree(sock) is not called
> - sock->base is always set to non-NULL when yenta_close() is called,
> therefore the check in yenta_close() is not necessary.
>
> Signed-off-by: Takeshi Yoshimura <yos@sslab.ics.keio.ac.jp>

Applied to the PCMCIA tree. Many thanks!

Dominik
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2015-06-14 22:21    [W:0.037 / U:0.660 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site