Messages in this thread | | | From | Lucas De Marchi <> | Date | Fri, 12 Jun 2015 19:45:00 -0300 | Subject | Re: [PATCH] i2c: designware: use enable on resume instead initialization |
| |
Hi Mika,
On Wed, Jun 10, 2015 at 4:55 AM, Mika Westerberg <mika.westerberg@linux.intel.com> wrote: > On Mon, Jun 08, 2015 at 02:50:28PM -0300, lucas.de.marchi@gmail.com wrote: >> @@ -320,7 +320,7 @@ static int dw_i2c_resume(struct device *dev) >> clk_prepare_enable(i_dev->clk); >> >> if (!i_dev->pm_runtime_disabled) >> - i2c_dw_init(i_dev); >> + i2c_dw_enable(i_dev); > > This will not work if the device power gets removed (for example being > put to D3cold) as it looses context.
Do you mean we should keep the i2c_dw_init() here?
-- Lucas De Marchi
| |