Messages in this thread | | | Date | Thu, 11 Jun 2015 22:57:25 -0500 | From | Timur Tabi <> | Subject | Re: [PATCH non-pretimeout 4/7] Watchdog: introduce ARM SBSA watchdog driver |
| |
fu.wei@linaro.org wrote: > + if (timeout <= gwdt->max_wor_timeout) > + writel_relaxed(timeout * gwdt->clk, > + gwdt->control_base + SBSA_GWDT_WOR); > + else > + writel_relaxed(gwdt->max_wor_timeout * gwdt->clk, > + gwdt->control_base + SBSA_GWDT_WOR);
You pre-calculate the maximum timeout possible already, so why do you need the if-statement?
Frankly, your non-pretimeout driver is almost identical to mine, which was posted weeks ago. At this point, you're really just copying my driver but putting your name on it.
-- Sent by an employee of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation.
| |