Messages in this thread |  | | Date | Fri, 12 Jun 2015 10:48:31 +0900 | From | Tejun Heo <> | Subject | Re: [PATCH] kernel/params.c: make use of unused but set variable |
| |
On Fri, Jun 12, 2015 at 10:57:24AM +0930, Rusty Russell wrote: > Linus Torvalds <torvalds@linux-foundation.org> writes: > > On Sun, Jun 7, 2015 at 5:00 PM, Tejun Heo <htejun@gmail.com> wrote: > > At most, it could be a "WARN_ON_ONCE()". Maybe even just silently > > ignore the error. But BUG_ON()? Hell no. > > Yeah, in practice it's already (1) paniced if we ran out of memory, or > (2) warned if we somehow tried to create two entries with the same name. > > So the WARN_ON_ONCE() is a bit... meh. How's this, too snarky?
Sounds pretty passive agressive to me. At least reply to the actual argument?
Thanks.
-- tejun
|  |