lkml.org 
[lkml]   [2015]   [Jun]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v5 02/10] x86: Compile-time asm code validation

    * Josh Poimboeuf <jpoimboe@redhat.com> wrote:

    > I should also mention that my proposed ia32_ptregs_common patch, which
    > duplicated the needed code, was more optimized for performance than code size.
    >
    > But if you're more worried about code size, we could turn ia32_ptregs_common
    > into a proper callable function, and then replace
    >
    > jmp ia32_ptregs_common
    >
    > with:
    >
    > call ia32_ptregs_common
    > ret
    >
    > So it becomes a regular call instead of a tail call. It only adds a few
    > instructions and the function is self-contained. Would that be good enough?

    No, debug info should not slow down the kernel, especially not code we write in
    assembly partly for performance.

    Thanks,

    Ingo


    \
     
     \ /
      Last update: 2015-06-11 08:21    [W:3.050 / U:0.628 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site