lkml.org 
[lkml]   [2015]   [Jun]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 1/2] staging/lustre/llite: remove LL_IOC_REMOVE_ENTRY handler
    From
    Date

    On Jun 10, 2015, at 3:08 AM, Sudip Mukherjee wrote:

    > On Wed, Jun 10, 2015 at 12:41:22AM -0400, green@linuxhacker.ru wrote:
    >> From: Oleg Drokin <green@linuxhacker.ru>
    >>
    >> It uses getname in unsafe manner and since it's to deal with corrupted
    >> or inconsistent filesystem, we are probably better to deal with
    >> it from lfsck anyway.
    > I am not sure but will it not break the userspace? There may be some
    > application who is using this ioctl.

    This is an ioctl for a relatively new "distributed namespace" feature.
    Our lustre control tool uses it in order to get rid of presumed
    incorrect entries that don't point anywhere. But in fact that's pretty
    risky and I am of the opinion this is best left to fsck to decide,
    it's too easy to create nameless directories otherwise
    (and even if we only allow sysadmin to do this, it's still not all that
    great of an idea).

    > And I think you missed removing the #define LL_IOC_REMOVE_ENTRY from
    > lustre_user.h which will not be used anymore.

    Good point.
    Thanks.

    Bye,
    Oleg


    \
     
     \ /
      Last update: 2015-06-10 09:41    [W:3.625 / U:0.036 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site