Messages in this thread |  | | Date | Wed, 10 Jun 2015 22:19:23 +0530 | From | Vinod Koul <> | Subject | Re: [PATCH v2 3/5] dmaengine: mv_xor: add support for a38x command in descriptor mode |
| |
On Mon, Jun 08, 2015 at 10:53:51PM +0200, Maxime Ripard wrote: > Hi Vinod, > > On Mon, Jun 08, 2015 at 04:04:47PM +0530, Vinod Koul wrote: > > On Tue, May 26, 2015 at 03:07:34PM +0200, Maxime Ripard wrote: > > > From: Lior Amsalem <alior@marvell.com> > > > > > > The Marvell Armada 38x SoC introduce new features to the XOR engine, > > > especially the fact that the engine mode (MEMCPY/XOR/PQ/etc) can be part of > > > the descriptor and not set through the controller registers. > > > > > > This new feature allows mixing of different commands (even PQ) on the same > > > channel/chain without the need to stop the engine to reconfigure the engine > > > mode. > > > > > > Refactor the driver to be able to use that new feature on the Armada 38x, > > > while keeping the old behaviour on the older SoCs. > > > > > > Signed-off-by: Lior Amsalem <alior@marvell.com> > > > Reviewed-by: Ofer Heifetz <oferh@marvell.com> > > > Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com> > > > --- > > > Documentation/devicetree/bindings/dma/mv-xor.txt | 2 +- > > > drivers/dma/mv_xor.c | 82 ++++++++++++++++++++---- > > > drivers/dma/mv_xor.h | 7 ++ > > > 3 files changed, 76 insertions(+), 15 deletions(-) > > > > > > diff --git a/Documentation/devicetree/bindings/dma/mv-xor.txt b/Documentation/devicetree/bindings/dma/mv-xor.txt > > > index 7c6cb7fcecd2..cc29c35266e2 100644 > > > --- a/Documentation/devicetree/bindings/dma/mv-xor.txt > > > +++ b/Documentation/devicetree/bindings/dma/mv-xor.txt > > > @@ -1,7 +1,7 @@ > > > * Marvell XOR engines > > > > > > Required properties: > > > -- compatible: Should be "marvell,orion-xor" > > > +- compatible: Should be "marvell,orion-xor" or "marvell,armada-380-xor" > > > > marvell,armada-380-xor doesnt seem to exist in binding ? > > I'm not sure what you mean, this patch precisely adds that compatible > to the bindings documentation. Ah my bad, didnt payrequired attention, trusted checkpatch warn.
-- ~Vinod
|  |