lkml.org 
[lkml]   [2015]   [Jun]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 1/1] x86 TSC: set X86_FEATURE_TSC_RELIABLE, per CPUID
On Mon, Jun 1, 2015 at 5:45 PM, Len Brown <lenb@kernel.org> wrote:
> On Mon, Jun 1, 2015 at 2:40 PM, Andy Lutomirski <luto@kernel.org> wrote:
>> On 05/30/2015 10:44 PM, Len Brown wrote:
>>>
>>> From: Len Brown <len.brown@intel.com>
>>>
>>> Speed cpu_up() by believing CPUID's "invariant TSC" flag,
>>> and skipping the TSC warp test on single socket systems.
>>
>>
>> I'm typing this email on a "Intel(R) Core(TM) i7-3930K CPU @ 3.20GHz" with a
>> "X79A-GD65 (8D) (MS-7760)" motherboard. (DO NOT BUY THAT MOTHERBOARD!)
>>
>> The brilliant stock firmware breaks TSC sync on bootup. Even with the
>> updated firmware I'm using, it's broken on resume from S3.
>
> So the stock firmware broke the TSC on boot _and_ S3.
> The updated firmware does not break the TSC on boot, but still breaks it on S3?

Exactly.

>
> For this board, please send the output from
> $ dmesg | grep -i tsc

[ 0.000000] tsc: Fast TSC calibration using PIT
[ 0.000000] tsc: Detected 3199.952 MHz processor
[ 0.192253] TSC deadline timer enabled
[ 1.712495] tsc: Refined TSC clocksource calibration: 3199.960 MHz
[ 2.712791] Switched to clocksource tsc

... suspend and resume ...

[ 61.414518] TSC synchronization [CPU#0 -> CPU#1]:
[ 61.414518] Measured 6137255520 cycles TSC warp between CPUs,
turning off TS clock.
[ 61.414522] tsc: Marking TSC unstable due to check_tsc_sync_source failed

>
> I would think we could detect this issue much faster than requesting
> the full 2ms test.
>
>> If you want to make this depend on X86_FEATURE_TSC_ADJUST and confirm that
>> all cores have the same IA32_TSC_ADJUST value, then maybe that would be
>> okay.
>
> That suggestion sounds reasonable.
>
> BTW, it also begs the question if Linux could actually *repair* the BIOS damage?

Quite possibly. Is there such thing as a single-socket CPU that
claims invariant CPU on which setting TSC_ADJUST to zero on all cores
won't result in a synchronized TSC? (This is moot for my CPU. I
don't have TSC_ADJUST.)

On a somewhat related note, why are we still calibrating the TSC
frequency based on the PIT? intel_pstate appears to know how to read
it off directly.

--Andy


\
 
 \ /
  Last update: 2015-06-02 03:41    [W:1.724 / U:0.724 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site