Messages in this thread | | | From | Arnd Bergmann <> | Subject | Re: [PATCH RESEND 3/3] drivers/rtc/sunxi: Replace deprecated rtc_tm_to_time() | Date | Mon, 01 Jun 2015 21:53:03 +0200 |
| |
On Friday 29 May 2015 23:04:37 Xunlei Pang wrote: > } > > - rtc_tm_to_time(alrm_tm, &time_set); > - rtc_tm_to_time(&tm_now, &time_now); > + time_set = rtc_tm_to_time64(alrm_tm); > + time_now = rtc_tm_to_time64(&tm_now); > if (time_set <= time_now) { > dev_err(dev, "Date to set in the past\n"); > return -EINVAL; > } > > + if (time_set > time_now + 255 * SEC_IN_DAY) { > + dev_err(dev, "Day must be in the range 0 - 255\n"); > + return -EINVAL; > + } > + >
So this driver also uses the two values just to do a comparison and to take the difference in seconds.
If we have a helper function that returns the difference between two rtc_tm values as a time64_t, we can use that for both this driver and isl1208.
Arnd
| |