lkml.org 
[lkml]   [2015]   [Jun]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: Can ovl_drop_write() be called earlier in ovl_dentry_open()
Date
Miklos Szeredi <miklos@szeredi.hu> wrote:

> > In ovl_dentry_open(), ovl_drop_write() is called after vfs_open() - but is
> > this actually necessary? Can't we just drop it post-copyup? After all,
> > that's all we wanted the write lock for, right?
>
> Hmm, that could result in a race where remount r/o of upper fs comes
> in between copy-up and vfs_open() so copy-up succeeds but the actual
> open fails. It's harmless, though, and not very likely. So I guess
> your patch is OK.

That race is there anyway if there's no copy up, right?

David


\
 
 \ /
  Last update: 2015-06-01 18:21    [W:0.056 / U:0.464 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site