Messages in this thread | | | Date | Sat, 9 May 2015 13:59:40 +0300 | From | Dan Carpenter <> | Subject | Re: [PATCH] staging: gdm724: adding kernel endianness header |
| |
On Fri, May 08, 2015 at 06:29:24PM -0500, Jaime Arrocha wrote: > >From TODO list: remove test for host endian > Included header to gather information about host endianness. > Please let me know if the code addition requires corrections > to meet standards. >
No. This isn't really an improvement. We need to get rid of ->host_ed entirely. Which is actually easy. Basically change gdm_cpu_to_dev16() and friends to do so something:
u16 gdm_cpu_to_dev16(struct gdm_endian *ed, u16 x) { if (ed->dev_ed == ENDIANNESS_LITTLE) return cpu_to_le16(x); else return cpu_to_be16(x); }
regards, dan carpenter
| |