This message generated a parse failure. Raw output follows here. Please use 'back' to navigate. From devnull@lkml.org Fri May 17 21:48:13 2024 >From spaans Fri May 8 20:42:26 2015 Received: from pop.ziggo.nl [212.54.42.19] by squeeze.vs19.net with POP3 (fetchmail-6.3.21) for (single-drop); Fri, 08 May 2015 20:42:26 +0200 (CEST) Received: from md2.tb.mail.iss.local ([212.54.42.146]) by mc5.tb.mail.iss.local (Dovecot) with LMTP id MAI+NDwDTVU5LQAAh0Kp1A for ; Fri, 08 May 2015 20:41:23 +0200 Received: from mx19.tb.mail.iss.as9143.net ([212.54.42.146]) by md2.tb.mail.iss.local (Dovecot) with LMTP id l2liJhEoLVWOWwAAH7GgQA ; Fri, 08 May 2015 20:43:14 +0200 Received: from vger.kernel.org ([209.132.180.67]) by mx19.tb.mail.iss.as9143.net with esmtp (Exim 4.82) (envelope-from ) id 1YqnD9-0005H4-8Q for bmw12-lkml@ziggo.nl; Fri, 08 May 2015 20:41:23 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932674AbbEHSlT (ORCPT ); Fri, 8 May 2015 14:41:19 -0400 Received: from saturn.retrosnub.co.uk ([178.18.118.26]:52643 "EHLO saturn.retrosnub.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932104AbbEHSlR (ORCPT ); Fri, 8 May 2015 14:41:17 -0400 Received: from localhost.localdomain (oag4.wlan.daa.dublin.eircom.net [83.71.193.244]) by saturn.retrosnub.co.uk (Postfix; Retrosnub mail submission) with ESMTPSA id AA7F140822; Fri, 8 May 2015 19:41:11 +0100 (BST) Message-Id: <554D0347.9000903@kernel.org> Date: Fri, 08 May 2015 14:41:11 -0400 From: Jonathan Cameron User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 Mime-Version: 1.0 To: Daniel Baluta Cc: lars@metafoo.de, jlbec@evilplan.org, knaack.h@gmx.de, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, octavian.purdila@intel.com, pebolle@tiscali.nl, patrick.porlan@intel.com, adriana.reus@intel.com, constantin.musca@intel.com, marten@intuitivea Subject: Re: [PATCH v6 0/4] Add initial configfs support for IIO References: <1431092025-14355-1-git-send-email-daniel.baluta@intel.com> In-Reply-To: <1431092025-14355-1-git-send-email-daniel.baluta@intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-Id: X-Mailing-List: linux-kernel@vger.kernel.org X-Ziggo-spamsetting: Instelling=Gemiddeld Scorelimiet=14 X-Ziggo-spambar: / X-Ziggo-spamscore: 0.0 X-Ziggo-spamreport: CMAE Analysis: v=2.1 cv=Is+yCuLg c=1 sm=0 tr=0 a=UK1r566ZdBxH71SXbqIOeA==:17 a=tJe01QhAHdwA:10 a=N659UExz7-8A:10 a=VwQbUJbxAAAA:8 a=cIF5Tx0qAAAA:8 a=2SkfY8vzAAAA:8 a=k7f7euTfAAAA:8 a=h1PgugrvaO0A:10 a=W0vUJOdyAAAA:8 a=Xb7tXuE-nzrRVNy7vy8A:9 a=Lbr4SxixwN1 X-Ziggo-Spam-Status: No X-Spam-Status: No X-Spam-Flag: No On 08/05/15 09:33, Daniel Baluta wrote: > This patchset introduces IIO software triggers, offers a way of configuring > them via configfs and adds the IIO hrtimer based interrupt source to be used > with software triggers. > > The arhitecture is now split in 3 parts, to remove all IIO trigger specific > parts from IIO configfs core: > > (1) IIO software triggers - are independent of configfs. > (2) IIO configfs - offers a generic way of creating IIO objects. So far we can > create software triggers. > (3) IIO hrtimer trigger - is the first interrupt source for software triggers > (with syfs to follow). Each trigger type can implement its own set of > attributes. I'm happy with the whole series, but given Lars' involvement would like to give him a bit of time for another look / reviewed-by / acked-by or similar. Obviously comments from anyone else welcome as well. Now all we need to do is all the other uses for configfs that we've discussed in earlier threads :) Easy really ;) > > Changes since v5: (after Lars comments) > * the most important change is that we moved sampling_frequency attribute > from configfs to trigger's directory in /sys. > * couple of const added to strings > * documentation to public API in sw_trigger.h > * replace pr_err with WARN_ONCE in trigger_make_group to avoid spamming > kernel log, but without leaving user clueless in case of errors. > * we still need to decide if we get a real gain by adding min/max limits > for sampling frequency in /config dir. Anyhow, this can be done in a later > patch. > * fix race in hrtimer_remove > > Changes since v4: > * patch 1/4 > - fixed "new line" nit in industrialio-sw-trigger.c > - added license header in sw_trigger.ho > * patch 2/4 > - none > * patch 3/4 > - none > * patch 4/4 > - removed "Further work" chapter in iio_configfs.txt > - added configfs-iio file in Documentation/ABI/testing > > Daniel Baluta (4): > iio: core: Introduce IIO software triggers > iio: core: Introduce IIO configfs support > iio: trigger: Introduce IIO hrtimer based trigger > iio: Documentation: Add IIO configfs documentation > > Documentation/ABI/testing/configfs-iio | 20 ++++ > Documentation/iio/iio_configfs.txt | 58 ++++++++++ > drivers/iio/Kconfig | 16 +++ > drivers/iio/Makefile | 2 + > drivers/iio/industrialio-configfs.c | 117 ++++++++++++++++++++ > drivers/iio/industrialio-sw-trigger.c | 115 +++++++++++++++++++ > drivers/iio/trigger/Kconfig | 10 ++ > drivers/iio/trigger/Makefile | 2 + > drivers/iio/trigger/iio-trig-hrtimer.c | 194 +++++++++++++++++++++++++++++++++ > include/linux/iio/sw_trigger.h | 85 +++++++++++++++ > 10 files changed, 619 insertions(+) > create mode 100644 Documentation/ABI/testing/configfs-iio > create mode 100644 Documentation/iio/iio_configfs.txt > create mode 100644 drivers/iio/industrialio-configfs.c > create mode 100644 drivers/iio/industrialio-sw-trigger.c > create mode 100644 drivers/iio/trigger/iio-trig-hrtimer.c > create mode 100644 include/linux/iio/sw_trigger.h > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/