lkml.org 
[lkml]   [2015]   [May]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH 1/3] gpiolib: Add missing dummies for the unified device properties interface
    On Thu, May 7, 2015 at 1:08 AM, Geert Uytterhoeven <geert@linux-m68k.org> wrote:
    > If GPIOLIB=n:
    >
    > drivers/leds/leds-gpio.c: In function ‘gpio_leds_create’:
    > drivers/leds/leds-gpio.c:187: error: implicit declaration of function ‘devm_get_gpiod_from_child’
    > drivers/leds/leds-gpio.c:187: warning: assignment makes pointer from integer without a cast
    >
    > Add dummies for fwnode_get_named_gpiod() and devm_get_gpiod_from_child()
    > for the !GPIOLIB case to fix this.
    >

    Geert,

    This patch looks good to me. Do you mind merging it through LED tree
    with other 2 more LED patches?

    Thanks,
    -Bryan


    > Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
    > Fixes: 40b7318319281b1b ("gpio: Support for unified device properties interface")
    > ---
    > include/linux/gpio/consumer.h | 15 +++++++++++++++
    > 1 file changed, 15 insertions(+)
    >
    > diff --git a/include/linux/gpio/consumer.h b/include/linux/gpio/consumer.h
    > index 3a7c9ffd5ab930b4..da042657dc31d7f5 100644
    > --- a/include/linux/gpio/consumer.h
    > +++ b/include/linux/gpio/consumer.h
    > @@ -406,6 +406,21 @@ static inline int desc_to_gpio(const struct gpio_desc *desc)
    > return -EINVAL;
    > }
    >
    > +/* Child properties interface */
    > +struct fwnode_handle;
    > +
    > +static inline struct gpio_desc *fwnode_get_named_gpiod(
    > + struct fwnode_handle *fwnode, const char *propname)
    > +{
    > + return ERR_PTR(-ENOSYS);
    > +}
    > +
    > +static inline struct gpio_desc *devm_get_gpiod_from_child(
    > + struct device *dev, const char *con_id, struct fwnode_handle *child)
    > +{
    > + return ERR_PTR(-ENOSYS);
    > +}
    > +
    > #endif /* CONFIG_GPIOLIB */
    >
    > /*
    > --
    > 1.9.1
    >


    \
     
     \ /
      Last update: 2015-05-08 20:01    [W:3.296 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site