Messages in this thread | | | From | Hartley Sweeten <> | Subject | RE: [PATCH 0/6] staging: comedi: gsc_hpdi: some clean-ups | Date | Fri, 8 May 2015 17:06:10 +0000 |
| |
On Tuesday, May 05, 2015 10:47 AM, Ian Abbott wrote: > Simplify (eliminate) the board type matching code, since only a single > board type is supported. Reformat the comments. Fix the checkpatch > issues. Use a better module description string. > > 1) staging: comedi: gsc_hpdi: tidy up comments > 2) staging: comedi: gsc_hpdi: remove multiple board type support > 3) staging: comedi: gsc_hpdi: usleep_range is preferred over udelay > 4) staging: comedi: gsc_hpdi: prefer using the BIT() macro > 5) staging: comedi: gsc_hpdi: use PCI_DEVICE_SUB() > 6) staging: comedi: gsc_hpdi: use a better MODULE_DESCRIPTION() > > drivers/staging/comedi/drivers/gsc_hpdi.c | 184 +++++++++++++----------------- > 1 file changed, 80 insertions(+), 104 deletions(-)
Reviewed-by: H Hartley Sweeten <hsweeten@visionengravers.com>
| |