Messages in this thread | | | Date | Fri, 8 May 2015 17:48:16 +0200 | From | Andrew Lunn <> | Subject | Re: [PATCH] net: mdio-gpio: Allow for unspecified bus id |
| |
On Fri, May 08, 2015 at 04:18:49PM +0200, Bert Vermeulen wrote: > When the bus id was supplied via a struct platform_device, the driver wasn't > handling -1 to mean an unspecified id of the only instance of this driver, > as the platform spec requires. > > Signed-off-by: Bert Vermeulen <bert@biot.com> > --- > drivers/net/phy/mdio-gpio.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/phy/mdio-gpio.c b/drivers/net/phy/mdio-gpio.c > index f5cddf5..7bd90db 100644 > --- a/drivers/net/phy/mdio-gpio.c > +++ b/drivers/net/phy/mdio-gpio.c > @@ -165,7 +165,10 @@ static struct mii_bus *mdio_gpio_bus_init(struct device *dev, > if (!new_bus->irq[i]) > new_bus->irq[i] = PHY_POLL; > > - snprintf(new_bus->id, MII_BUS_ID_SIZE, "gpio-%x", bus_id); > + if (bus_id != -1) > + snprintf(new_bus->id, MII_BUS_ID_SIZE, "gpio-%x", bus_id); > + else > + strncpy(new_bus->id, "gpio", MII_BUS_ID_SIZE);
Hi Bert
What happens if there are multiple platform_device's with -1? You should probably be using use idr_alloc().
Andrew
| |