Messages in this thread | | | Date | Fri, 8 May 2015 11:03:45 -0400 | From | Steven Rostedt <> | Subject | Re: [PATCH] x86: force inlining of atomic ops |
| |
On Fri, 8 May 2015 12:26:02 +0200 Denys Vlasenko <dvlasenk@redhat.com> wrote:
> This patch fixes this for x86 atomic ops via s/inline/__always_inline/. > This decreases allyesconfig kernel by about 25k: > > text data bss dec hex filename > 82399481 22255416 20627456 125282353 777a831 vmlinux.before > 82375570 22255544 20627456 125258570 7774b4a vmlinux
I agree, there's no reason that atomic_* functions should not be inlined.
Acked-by: Steven Rostedt <rostedt@goodmis.org>
-- Steve
> > Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com> > CC: Steven Rostedt <rostedt@goodmis.org> > CC: Ingo Molnar <mingo@kernel.org> > CC: Borislav Petkov <bp@alien8.de> > CC: "H. Peter Anvin" <hpa@zytor.com> > CC: Andy Lutomirski <luto@amacapital.net> > CC: Frederic Weisbecker <fweisbec@gmail.com> > CC: Alexei Starovoitov <ast@plumgrid.com> > CC: Will Drewry <wad@chromium.org> > CC: Kees Cook <keescook@chromium.org> > CC: x86@kernel.org > CC: linux-kernel@vger.kernel.org > --- > arch/x86/include/asm/atomic.h | 28 ++++++++++++++-------------- > 1 file changed, 14 insertions(+), 14 deletions(-) >
| |