lkml.org 
[lkml]   [2015]   [May]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v4] power_supply: Add support for Richtek rt9455 battery charger
From
2015-05-08 20:58 GMT+09:00 Anda-Maria Nicolae <anda-maria.nicolae@intel.com>:
> diff --git a/drivers/power/Kconfig b/drivers/power/Kconfig
> index 4091fb0..b2b230c 100644
> --- a/drivers/power/Kconfig
> +++ b/drivers/power/Kconfig
> @@ -439,6 +439,13 @@ config BATTERY_RT5033
> The fuelgauge calculates and determines the battery state of charge
> according to battery open circuit voltage.
>
> +config CHARGER_RT9455
> + tristate "Richtek RT9455 battery charger driver"
> + depends on I2C && GPIOLIB
> + depends on REGMAP_I2C

Like I said previously, I still think you need to select it, not
depend on it. This is not a user-selectable option, so depending on it
may hide your driver. If you are unsure in such case you can always:
$ git grep REGMAP_I2C

Rest looks fine to me, so with the change above (s/depends on/select/):
Reviewed-by: Krzysztof Kozlowski <k.kozlowski.k@gmail.com>

Best regards,
Krzysztof


\
 
 \ /
  Last update: 2015-05-08 14:21    [W:0.028 / U:0.036 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site