Messages in this thread | | | Date | Thu, 7 May 2015 17:32:31 +0200 (CEST) | From | Julia Lawall <> | Subject | Re: [HPDD-discuss] [PATCH] staging: lustre: code cleanup - variable declaration spacing |
| |
On Thu, 7 May 2015, Dan Carpenter wrote:
> On Thu, May 07, 2015 at 03:36:05AM +0000, Dilger, Andreas wrote: > > On 2015/05/06, 6:02 AM, "Mike Shuey" <shuey@purdue.edu> wrote: > > > > >Clean up spacing in some variable declarations, to be more consistent. > > > > > >It's small, but I need to start somewhere. Please let me know if I'm not > > >adhering to proper procedure for trivial cleanups. > > > > It's actually Lustre coding style to align the variable declarations. > > Is this something that causes checkpatch.pl to complain? If not, I'd > > prefer not to change all of these declarations, since it causes a lot > > of code churn for very little benefit. > > In theory it's nice, but in reality aligning variables doesn't work in > .c files. If you look at the patch, almost every declaration block uses > higgledy piggledy alignment.
Probably the use of tabs and spaces is not consistent.
julia
| |