lkml.org 
[lkml]   [2015]   [May]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 01/10] arch: introduce __pfn_t for persistent memory i/o
Hi Dan,

On Wed, 06 May 2015 16:04:59 -0400 Dan Williams <dan.j.williams@intel.com> wrote:
>
> diff --git a/include/asm-generic/pfn.h b/include/asm-generic/pfn.h
> new file mode 100644
> index 000000000000..91171e0285d9
> --- /dev/null
> +++ b/include/asm-generic/pfn.h
> @@ -0,0 +1,51 @@
> +#ifndef __ASM_PFN_H
> +#define __ASM_PFN_H
> +
> +#ifndef __pfn_to_phys
> +#define __pfn_to_phys(pfn) ((dma_addr_t)(pfn) << PAGE_SHIFT)

Why dma_addr_t and not phys_addr_t? i.e. it could use a comment if it
is correct.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2015-05-07 17:01    [W:0.147 / U:1.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site