Messages in this thread | | | Date | Thu, 7 May 2015 10:46:07 -0400 (EDT) | From | Alan Stern <> | Subject | Re: [PATCH 02/10] drivers:host:fsl: Use ehci_overrides structure for EHCI drv |
| |
On Thu, 7 May 2015, Ramneek Mehresh wrote:
> Make use of ehci_driver_overrides structure for ehci-fsl > driver > > Signed-off-by: Ramneek Mehresh <ramneek.mehresh@freescale.com>
You need to change a lot more than this. See commit a76dd463c58e (USB: EHCI: make ehci-orion a separate driver) as an example of what is needed. In the end, ehci-fsl.ko should be a new driver module, not compiled into ehci-hcd.ko.
> + ehci_init_driver(driver, &ehci_fsl_overrides); > + driver->product_desc = "Freescale On-Chip EHCI Host Controller"; > + driver->start = ehci_run; > + driver->start_port_reset = ehci_start_port_reset;
Why do you want to override driver->start? The default value for this field is already set to ehci_run.
Alan Stern
| |