Messages in this thread | | | Date | Thu, 7 May 2015 11:15:20 -0300 | From | Arnaldo Carvalho de Melo <> | Subject | Re: [PATCH V8 7/8] perf, x86: introduce PERF_RECORD_LOST_SAMPLES |
| |
Em Thu, May 07, 2015 at 01:54:46PM +0200, Peter Zijlstra escreveu: > On Thu, May 07, 2015 at 01:35:24PM +0200, Peter Zijlstra wrote: > > > > - dropped the @id field from the record, it is already included in the > > @sample_id values. > > Hmm, this would force people to use sample_id; which in general is a > good idea, but should we really force that on people?
Well, if there are more than one sample, we need it, right? If there is just one, we don't need it, what is different? Am I needing (even more) coffee?
/me goes read some code...
- Arnaldo
| |