Messages in this thread | | | From | David Howells <> | Subject | Re: [PATCH] MODSIGN: Change default key details [ver #2] | Date | Thu, 07 May 2015 12:00:58 +0100 |
| |
Michal Marek <mmarek@suse.cz> wrote:
> are you fine with these two patches? > > https://lkml.org/lkml/2015/2/20/546 > https://lkml.org/lkml/2015/5/4/614
Yeah, I think so. Your reasoning on the first one is sound - but is it possible for $(objtree) to != $(srctree) even when they're coincident. I like Linus's use of the filechk macro on the second - but we shouldn't overwrite keys someone has manually placed in the tree if the key generation template changes due to git pull altering kernel/Makefile.
Sometimes I think makescript is like trying to program in Prolog - but worse.
David
| |