lkml.org 
[lkml]   [2015]   [May]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.16.y-ckt 126/180] ACPICA: Tables: Don't release ACPI_MTX_TABLES in acpi_tb_install_standard_table().
    Date
    3.16.7-ckt11 -stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Octavian Purdila <octavian.purdila@intel.com>

    commit 77ddc2fe08329e375505bc36a3df3233fe57317b upstream.

    ACPICA commit c70434d4da13e65b6163c79a5aa16b40193631c7

    ACPI_MTX_TABLES is acquired and released by the callers of
    acpi_tb_install_standard_table() so releasing it in the function itself is
    causing the following error in Linux kernel if the table is reloaded:

    ACPI Error: Mutex [0x2] is not acquired, cannot release (20141107/utmutex-321)
    Call Trace:
    [<ffffffff81b0bd48>] dump_stack+0x4f/0x7b
    [<ffffffff81546bf5>] acpi_ut_release_mutex+0x47/0x67
    [<ffffffff81544357>] acpi_load_table+0x73/0xcb

    Link: https://github.com/acpica/acpica/commit/c70434d4
    Signed-off-by: Octavian Purdila <octavian.purdila@intel.com>
    Signed-off-by: Lv Zheng <lv.zheng@intel.com>
    Signed-off-by: Bob Moore <robert.moore@intel.com>
    Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
    Signed-off-by: Luis Henriques <luis.henriques@canonical.com>
    ---
    drivers/acpi/acpica/tbinstal.c | 1 -
    1 file changed, 1 deletion(-)

    diff --git a/drivers/acpi/acpica/tbinstal.c b/drivers/acpi/acpica/tbinstal.c
    index 755b90c40ddf..c0b39f304ea3 100644
    --- a/drivers/acpi/acpica/tbinstal.c
    +++ b/drivers/acpi/acpica/tbinstal.c
    @@ -346,7 +346,6 @@ acpi_tb_install_standard_table(acpi_physical_address address,
    */
    acpi_tb_uninstall_table(&new_table_desc);
    *table_index = i;
    - (void)acpi_ut_release_mutex(ACPI_MTX_TABLES);
    return_ACPI_STATUS(AE_OK);
    }
    }

    \
     
     \ /
      Last update: 2015-05-07 12:41    [W:4.022 / U:0.044 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site