Messages in this thread | | | Date | Thu, 07 May 2015 10:56:45 +0100 | From | Sudeep Holla <> | Subject | Re: [PATCH] cpuidle: Handle tick_broadcast_enter() failure gracefully |
| |
Hi Preeti,
On 07/05/15 06:26, Preeti U Murthy wrote: > When a CPU has to enter an idle state where tick stops, it makes a call > to tick_broadcast_enter(). The call will fail if this CPU is the > broadcast CPU. Today, under such a circumstance, the arch cpuidle code > handles this CPU. This is not convincing because not only are we not > aware what the arch cpuidle code does, but we also do not account for > the idle state residency time and usage of such a CPU. > > This scenario can be handled better by simply asking the cpuidle > governor to choose an idle state where in ticks do not stop. To > accommodate this change move the setting of runqueue idle state from the > core to the cpuidle driver, else the rq->idle_state will be set wrong. > > Signed-off-by: Preeti U Murthy <preeti@linux.vnet.ibm.com> > --- > Based on linux-pm/bleeding-edge
I am unable to apply this patch cleanly on linux-pm/bleeding-edge I think it conflicts with few patches that Rafael posted recently which are in the branch now.
Regards, Sudeep
| |