lkml.org 
[lkml]   [2015]   [May]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] serial: xuartps: add __init to earlycon write method
Date
On Thursday 07 May 2015 18:14:43 you wrote:
> 2015-05-07 18:08 GMT+09:00 Arnd Bergmann <arnd@arndb.de>:
> > On Thursday 07 May 2015 18:02:39 Masahiro Yamada wrote:
> >> @@ -1075,7 +1075,8 @@ static void cdns_uart_console_putchar(struct uart_port *port, int ch)
> >> writel(ch, port->membase + CDNS_UART_FIFO_OFFSET);
> >> }
> >>
> >> -static void cdns_early_write(struct console *con, const char *s, unsigned n)
> >> +static void __init cdns_early_write(struct console *con, const char *s,
> >> + unsigned n)
> >> {
> >> struct earlycon_device *dev = con->data;
> >>
> >>
> >
> > Why?
> >
>
> I thought this function is used during the early boot stage.
>
> I am seeing drivers/tty/serial/8250/8250_early.c
> for reference.
>
> All the functions in this file are marked as __init.
>
> Perhaps, am I misunderstanding?
>

Makes sense, please explain that in the commit message and send the
patch again.

Arnd


\
 
 \ /
  Last update: 2015-05-07 12:01    [W:0.086 / U:0.020 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site