Messages in this thread | | | Date | Thu, 7 May 2015 11:39:08 +0300 | From | Dan Carpenter <> | Subject | Re: [PATCH] staging: fbtft: force cast to non-__iomem pointer |
| |
On Wed, May 06, 2015 at 02:34:49PM -0700, Garret Kelly wrote: > > Can't we fix this properly, to use the correct type of pointer instead > > for non-__iomem allocations? > > You mean making an alternate screen_base pointer inside fb_info that > isn't __iomem? There are already a bunch of framebuffer drivers that > (ab)use screen_base to store non-__iomem pointers, so this didn't > strike me as too far out of line.
You could add a new pointer or you could just make ->screen_base a union. I'm not sure which is the best.
regards, dan carpenter
| |