Messages in this thread | | | Date | Thu, 07 May 2015 18:47:17 -0700 | From | Guenter Roeck <> | Subject | Re: [PATCH 1/2] watchdog: dw_wdt: Use a mutex, not a spinlock |
| |
On 05/07/2015 03:09 PM, Doug Anderson wrote: > Right now the dw_wdt uses a spinlock to protect dw_wdt_open(). The > problem is that while holding the spinlock we call: > -> dw_wdt_set_top() > -> dw_wdt_top_in_seconds() > -> clk_get_rate() > -> clk_prepare_lock() > -> mutex_lock() > > Locking a mutex while holding a spinlock is not allowed and leads to > warnings like "BUG: spinlock wrong CPU on CPU#1", among other > problems. > > There's no reason to use a spinlock, so switch to a mutex. > > Signed-off-by: Doug Anderson <dianders@chromium.org>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
| |