lkml.org 
[lkml]   [2015]   [May]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v4 04/10] eeprom: Add a simple EEPROM framework for eeprom consumers
    On Mon, Mar 30, 2015 at 10:57:50PM +0100, Srinivas Kandagatla wrote:

    > +
    > + for (i = 0; i < cell->nblocks; i++) {
    > + rc = regmap_raw_read(eeprom->regmap, cell->blocks[i].offset,
    > + buf + offset, cell->blocks[i].count);

    I *think* this is probably OK but please double check that the count
    here is in bytes rather than words, it's a bit confusing since I'd read
    a count as being in words. Otherwise I think the regmap usage here all
    looks good.
    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2015-05-06 20:01    [W:3.249 / U:0.156 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site