Messages in this thread | | | Date | Wed, 06 May 2015 08:23:48 -0600 | From | Jens Axboe <> | Subject | Re: [PATCH v2] splice: sendfile() at once fails for big files |
| |
On 05/05/2015 09:41 PM, Linus Torvalds wrote: > Jens, ping? > > The test results should make this a no-brainer, but I hate how random > these flag ops.
Missed the original, apparently. I too am confused how this is a correctness fix and not just an optimization.
+ if (read_len < len) + sd->flags |= SPLICE_F_MORE; + else if (!more) + sd->flags &= ~SPLICE_F_MORE;
Should that check be for 'more', not '!more'?
-- Jens Axboe
| |