Messages in this thread Patch in this message | | | Subject | Re: [PATCH v2 3/5] toshiba_acpi: Cleanup blank lines after comment blocks | From | Joe Perches <> | Date | Tue, 05 May 2015 07:18:40 -0700 |
| |
On Mon, 2015-05-04 at 11:15 -0600, Azael Avalos wrote: > This patch removes some blank lines after comment blocks, capitalizes > some comments first words and adds a few comments to the beggining > of some functions.
I think blank lines after comments are generally OK.
This is now inconsistent about
/* * short comment */
and
/* short comment */
Not all function blocks need introductory comments.
> diff --git a/drivers/platform/x86/toshiba_acpi.c b/drivers/platform/x86/toshiba_acpi.c [] > @@ -78,10 +78,9 @@ MODULE_LICENSE("GPL"); > * SCI stands for "System Configuration Interface" which aim is to > * conceal differences in hardware between different models. > */ > - > #define TCI_WORDS 6
It's sometimes nice to have blank lines after long block comments. > -/* operations */ > +/* Operations */
I think these sentence case changes aren't better.
| |