lkml.org 
[lkml]   [2015]   [May]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/1 linux-next] PNP: move EXPORT_SYMBOL after functions


> On 04 May 2015 at 23:30 "Rafael J. Wysocki" <rjw@rjwysocki.net> wrote:
>
>
> On Saturday, May 02, 2015 06:01:21 PM Fabian Frederick wrote:
> > EXPORT macro must be placed directly after functions.
> > See Documentation/CodingStyle Chapter 6
>
> Well, why is this change an improvement?
>
> Yes, it makes an old file follow the new(er) Documentation/CodingStyl,
> but what exactly is the benefit?
>
> Mind you, there are more files with EXPORT_SYMBOL(_GPL) at the end.
> Are you going to hunt for them now or something?

Hi Rafael,
       
        AFAIK it just brings more readability. I sent you this one while fixing
warnings in 2 PNPACPI patches but of course you can ignore it :)
Fortunately, I don't plan to send a patch for each EXPORT_SYMBOL(_GPL) "problem"
:)

Regards,
Fabian

>
>
> --
> I speak only for myself.
> Rafael J. Wysocki, Intel Open Source Technology Center.


\
 
 \ /
  Last update: 2015-05-05 20:21    [W:0.037 / U:0.852 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site