lkml.org 
[lkml]   [2015]   [May]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v8 00/23] IB/Verbs: IB Management Helpers


On 05/05/2015 04:16 PM, Or Gerlitz wrote:
> On 5/5/2015 3:50 PM, Michael Wang wrote:
>> Since v7:
>> * Thanks to Doug, Ira, Devesh for the testing:-)
>> * Thanks for the comments from or, Doug, Ira, Jason:-)
>> Please remind me if anything missed:-P
>> * Use rdma_cap_XX() instead of cap_XX() for readability
>> * Remove CC list in git log for maintainability
>> * Use bool as return value
>> * Updated github repository to v8
>
> Didn't you see that patches 15~23 will be squashed into one?

I missed the conversation on that, you mentioned to remove the
CC list but don't want to merge the patches, correct?

>
>
> Also, when you post version N you need not only to list the changes since version N-1 but rather also to keep the full changes since Vx for x=1...N-2, reviewers needs not chase your previous cover letters and see if/whatwent wrong, specifically with a sensitive series like this one.

That maybe too long and with some outdated info, I can reserve
the log since this version if it was preferred by folks.

>
> So if/when there's V9, use that practice, and for the time being, reply on the V8 cover letter with the full listing of changes

I'm using git send-mail which reply on the cover of each version,
not sure how to reply on a prev cover? and that won't start a new
thread for the new version, isn't it?

Regards,
Michael Wang

>
> Or.
>
>


\
 
 \ /
  Last update: 2015-05-05 20:01    [W:0.168 / U:0.104 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site