Messages in this thread | | | Date | Tue, 05 May 2015 11:12:52 -0400 | From | Boris Ostrovsky <> | Subject | Re: [PATCH v2 3/7] ACPI / processor: Introduce invalid_logical_cpuid() |
| |
On 05/04/2015 10:46 PM, Hanjun Guo wrote: > In ACPI processor drivers, we use direct comparisons of cpu logical > id with -1 which are error prone in case logical cpuid is accidentally > assinged an error code and prevents us from returning an error-encoding > cpuid directly in some cases.
Which is exactly what Xen code does (xen_pcpu_id() and xen_hotadd_cpu()). And patch 4/7 fixes this.
-boris
> > So introduce invalid_logical_cpuid() to identify cpu with invalid > logical cpu num, then it will be used to replace the direct comparisons > with -1.
| |