Messages in this thread | | | Date | Tue, 5 May 2015 07:18:11 -0400 | Subject | Re: [PATCH] drivers: dma: amba-pl08x: Supress spaces in indentation | From | Leonardo Carreras <> |
| |
Dear Vinod,
On Mon, May 4, 2015 at 11:32 PM, Vinod Koul <vinod.koul@intel.com> wrote: > On Mon, May 04, 2015 at 09:32:27PM -0400, Leonardo Carreras wrote: >> Removed checkpatch reported spaces in indentation. >> > You should look at git log to come up with patch tags for a subsystem, if > you had done that you would have noticed that we use dmaengine:.... > > Also you should have run checkpatch and that would have told you a typo in > changelog >
As this was my first attempt, I have to say sorry for the inconveniences. I will definitely take this in account.
> Lastly, you should mention which error/warn your are fixing in log. >
It was an error in line 477, sorry for that too.
> I have fixed first two and applied this > > -- > ~Vinod > >> Signed-off-by: Leonardo Carreras <leocarreras89@gmail.com> >> --- >> drivers/dma/amba-pl08x.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/dma/amba-pl08x.c b/drivers/dma/amba-pl08x.c >> index 49d396e..a76df61 100644 >> --- a/drivers/dma/amba-pl08x.c >> +++ b/drivers/dma/amba-pl08x.c >> @@ -474,7 +474,7 @@ static void pl08x_terminate_phy_chan(struct pl08x_driver_data *pl08x, >> u32 val = readl(ch->reg_config); >> >> val &= ~(PL080_CONFIG_ENABLE | PL080_CONFIG_ERR_IRQ_MASK | >> - PL080_CONFIG_TC_IRQ_MASK); >> + PL080_CONFIG_TC_IRQ_MASK); >> >> writel(val, ch->reg_config); >> >> -- >> 1.7.9.5 >> > > --
| |