Messages in this thread | | | Date | Tue, 5 May 2015 09:35:17 +0200 | From | Johan Hovold <> | Subject | Re: [PATCH] cypress_m8: please add vendor/product id to support Prior Scientific OptiScan2 |
| |
On Mon, May 04, 2015 at 11:45:11AM -0400, Ian Stakenvicius wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA256 > > The microscope automation controllers from Prior Scientific, > specifically the OptiScan2 controller (the only one I have access to at > present) use a Cypress CY7C64013-SXC for USB->serial conversion. I've > tested the following patch against drivers/usb/serial/cypress_m8.{c,h} > with success (it just adds the vendor-id and product-id), and I was > wondering if it could be added to the kernel?
Thanks for the patch. Please always run your patches through scripts/checkpatch.pl before submitting, it would have told you that you forgot to sign-off.
You should include the patch inline in your mail rather than as an attachment (also read Documentation/SubmittingPatches). git format-patch and send-mail can be quite useful.
An example of what such a patch could look like can be found here:
http://www.spinics.net/lists/linux-usb/msg123868.html
Care to fix that up and resend?
Thanks, Johan
| |