lkml.org 
[lkml]   [2015]   [May]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 3.2 052/221] dm snapshot: fix a possible invalid memory access on unload
    3.2.69-rc1 review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Mikulas Patocka <mpatocka@redhat.com>

    commit 22aa66a3ee5b61e0f4a0bfeabcaa567861109ec3 upstream.

    When the snapshot target is unloaded, snapshot_dtr() waits until
    pending_exceptions_count drops to zero. Then, it destroys the snapshot.
    Therefore, the function that decrements pending_exceptions_count
    should not touch the snapshot structure after the decrement.

    pending_complete() calls free_pending_exception(), which decrements
    pending_exceptions_count, and then it performs up_write(&s->lock) and it
    calls retry_origin_bios() which dereferences s->origin. These two
    memory accesses to the fields of the snapshot may touch the dm_snapshot
    struture after it is freed.

    This patch moves the call to free_pending_exception() to the end of
    pending_complete(), so that the snapshot will not be destroyed while
    pending_complete() is in progress.

    Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>
    Signed-off-by: Mike Snitzer <snitzer@redhat.com>
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    drivers/md/dm-snap.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    --- a/drivers/md/dm-snap.c
    +++ b/drivers/md/dm-snap.c
    @@ -1444,8 +1444,6 @@ out:
    full_bio->bi_end_io = pe->full_bio_end_io;
    full_bio->bi_private = pe->full_bio_private;
    }
    - free_pending_exception(pe);
    -
    increment_pending_exceptions_done_count();

    up_write(&s->lock);
    @@ -1462,6 +1460,8 @@ out:
    }

    retry_origin_bios(s, origin_bios);
    +
    + free_pending_exception(pe);
    }

    static void commit_callback(void *context, int success)


    \
     
     \ /
      Last update: 2015-05-05 04:21    [W:4.034 / U:0.104 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site