lkml.org 
[lkml]   [2015]   [May]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 3.2 070/221] USB: serial: fix potential use-after-free after failed probe
    3.2.69-rc1 review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Johan Hovold <johan@kernel.org>

    commit 07fdfc5e9f1c966be8722e8fa927e5ea140df5ce upstream.

    Fix return value in probe error path, which could end up returning
    success (0) on errors. This could in turn lead to use-after-free or
    double free (e.g. in port_remove) when the port device is removed.

    Fixes: c706ebdfc895 ("USB: usb-serial: call port_probe and port_remove
    at the right times")
    Signed-off-by: Johan Hovold <johan@kernel.org>
    Acked-by: Greg Kroah-Hartman <greg@kroah.com>
    [bwh: Backported to 3.2: adjust context]
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    drivers/usb/serial/bus.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/usb/serial/bus.c
    +++ b/drivers/usb/serial/bus.c
    @@ -73,7 +73,7 @@ static int usb_serial_device_probe(struc
    retval = device_create_file(dev, &dev_attr_port_number);
    if (retval) {
    if (driver->port_remove)
    - retval = driver->port_remove(port);
    + driver->port_remove(port);
    goto exit;
    }



    \
     
     \ /
      Last update: 2015-05-05 04:21    [W:4.209 / U:0.148 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site