Messages in this thread | | | Date | Mon, 4 May 2015 16:14:43 -0500 | From | Josh Poimboeuf <> | Subject | Re: [PATCH v2 2/2] x86, stackvalidate: Add asm frame pointer setup macros |
| |
On Mon, May 04, 2015 at 01:33:53PM -0700, H. Peter Anvin wrote: > On 05/04/2015 01:23 PM, Josh Poimboeuf wrote: > > + __ASM_SIZE(push, _cfi) %_ASM_BP > > + __ASM_SIZE(pop, _cfi) %_ASM_BP > > This seems ridiculous. push/pop only come in one size per > architecture(*). Can we make it so that just push_cfi and pop_cfi do > the right things?
Yeah, the separated pushq_cfi and pushl_cfi macros aren't really necessary. I'm guessing they were made separate in order to have a consistent naming interface with movq_cfi and movl_cfi.
I'm not sure about which way is better. But I can replace them with new push_cfi and pop_cfi macros if you like.
-- Josh
| |