lkml.org 
[lkml]   [2015]   [May]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 2/2] x86, stackvalidate: Add asm frame pointer setup macros
On Mon, May 04, 2015 at 01:33:53PM -0700, H. Peter Anvin wrote:
> On 05/04/2015 01:23 PM, Josh Poimboeuf wrote:
> > + __ASM_SIZE(push, _cfi) %_ASM_BP
> > + __ASM_SIZE(pop, _cfi) %_ASM_BP
>
> This seems ridiculous. push/pop only come in one size per
> architecture(*). Can we make it so that just push_cfi and pop_cfi do
> the right things?

Yeah, the separated pushq_cfi and pushl_cfi macros aren't really
necessary. I'm guessing they were made separate in order to have a
consistent naming interface with movq_cfi and movl_cfi.

I'm not sure about which way is better. But I can replace them with new
push_cfi and pop_cfi macros if you like.

--
Josh


\
 
 \ /
  Last update: 2015-05-04 23:41    [W:0.142 / U:0.300 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site