Messages in this thread | | | Date | Wed, 29 Apr 2015 19:23:33 -0300 | From | Arnaldo Carvalho de Melo <> | Subject | Re: [PATCH] perf: probe: avoid segfault if passed with ''. |
| |
Em Tue, Apr 28, 2015 at 08:46:09AM +0000, Wang Nan escreveu: > Since parse_perf_probe_point() deals with a user passed argument, we > should not assume it to be a valid string. > > Without this patch, if pass '' to perf probe, a segfault raises: > > $ perf probe -a '' > Segmentation fault > > This patch checks argument of parse_perf_probe_point() before > string processing. > > After this patch: > > $ perf probe -a '' > > usage: perf probe [<options>] 'PROBEDEF' ['PROBEDEF' ...] > or: perf probe [<options>] --add 'PROBEDEF' [--add 'PROBEDEF' ...] > ...
Thanks, applied to perf/urgent.
- Arnaldo
| |