lkml.org 
[lkml]   [2015]   [May]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/7] x86/intel_rdt: Adds support for Class of service management


On Sat, 2 May 2015, Peter Zijlstra wrote:

> On Fri, May 01, 2015 at 06:36:36PM -0700, Vikas Shivappa wrote:
>> +static inline bool cat_supported(struct cpuinfo_x86 *c)
>
> Is search and replace really that hard?
>
>> +/*
>> +* Called with the rdt_group_mutex held.
>> +*/
>
> Whitespace damaged and pointless comment.
>
>> +static int rdt_free_closid(struct intel_rdt *ir)
>> +{
>> +
>
> superfluous whitespace
>
>> + lockdep_assert_held(&rdt_group_mutex);
>> +
>> + WARN_ON(!ccmap[ir->clos].cgrp_count);
>> + ccmap[ir->clos].cgrp_count--;
>> + if (!ccmap[ir->clos].cgrp_count)
>> + clear_bit(ir->clos, rdtss_info.closmap);
>> +
>> + return 0;
>> +}
>
>
> These patches really are very sloppy..

Will resend the updated patch - most of the changes here are removed in next
patch.

Thanks,
Vikas

>


\
 
 \ /
  Last update: 2015-05-04 19:41    [W:0.061 / U:0.028 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site