Messages in this thread | | | Date | Mon, 04 May 2015 15:25:30 +0200 | From | Richard Weinberger <> | Subject | Re: [PATCH] hostfs: Use correct mask for file mode |
| |
Am 04.05.2015 um 15:22 schrieb Geert Uytterhoeven: > On Mon, May 4, 2015 at 2:53 PM, Richard Weinberger <richard@nod.at> wrote: >> --- a/fs/hostfs/hostfs_kern.c >> +++ b/fs/hostfs/hostfs_kern.c >> @@ -581,7 +581,7 @@ static int hostfs_create(struct inode *dir, struct dentry *dentry, umode_t mode, >> if (name == NULL) >> goto out_put; >> >> - fd = file_create(name, mode & S_IFMT); >> + fd = file_create(name, mode & 0777); > > "(S_IRWXU | S_IRWXG | S_IRWXO)"?
I thought about that too but did not see a real benefit as 0777 is well known and self describing.
Thanks, //richard
| |