lkml.org 
[lkml]   [2015]   [May]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] tick-broadcast: Fix the printing of broadcast masks
Ping.

Any comments on this patch ?

Regards
Preeti U Murthy
On 04/28/2015 02:15 PM, Preeti U Murthy wrote:
> Today the number of bits of the broadcast masks that is output into
> /proc/timer_list is sizeof(unsigned long). This means that on machines
> with larger number of CPUs, the bitmasks of CPUs beyond this range do
> not appear.
>
> Fix this by using bitmap printing through "%*pb" instead, so as to
> output the broadcast masks for the range of nr_cpu_ids into
> /proc/timer_list.
>
> Signed-off-by: Preeti U Murthy <preeti@linux.vnet.ibm.com>
> ---
>
> kernel/time/timer_list.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/kernel/time/timer_list.c b/kernel/time/timer_list.c
> index c82b03c..1afc726 100644
> --- a/kernel/time/timer_list.c
> +++ b/kernel/time/timer_list.c
> @@ -269,11 +269,11 @@ static void timer_list_show_tickdevices_header(struct seq_file *m)
> {
> #ifdef CONFIG_GENERIC_CLOCKEVENTS_BROADCAST
> print_tickdevice(m, tick_get_broadcast_device(), -1);
> - SEQ_printf(m, "tick_broadcast_mask: %08lx\n",
> - cpumask_bits(tick_get_broadcast_mask())[0]);
> + SEQ_printf(m, "tick_broadcast_mask: %*pb\n",
> + cpumask_pr_args(tick_get_broadcast_mask()));
> #ifdef CONFIG_TICK_ONESHOT
> - SEQ_printf(m, "tick_broadcast_oneshot_mask: %08lx\n",
> - cpumask_bits(tick_get_broadcast_oneshot_mask())[0]);
> + SEQ_printf(m, "tick_broadcast_oneshot_mask: %*pb\n",
> + cpumask_pr_args(tick_get_broadcast_oneshot_mask()));
> #endif
> SEQ_printf(m, "\n");
> #endif
>
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/linuxppc-dev
>



\
 
 \ /
  Last update: 2015-05-04 08:21    [W:0.041 / U:0.164 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site