lkml.org 
[lkml]   [2015]   [May]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v2 2/5] usb: composite: fix usb_function_activate/deactivate functions
    Date
    Using usb_gadget_disconnect to make gadget temporarily invisible to host
    doesn't provide desired result, because gadget is connected immediately
    after binding regardless to previous usb_gadget_disconnect() calls.

    For this reason we use usb_gadget_deactivate() instead of
    usb_gadget_disconnect() to make it working as expected.

    Signed-off-by: Robert Baldyga <r.baldyga@samsung.com>
    ---
    drivers/usb/gadget/composite.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/drivers/usb/gadget/composite.c b/drivers/usb/gadget/composite.c
    index 4e3447b..9ed77f4 100644
    --- a/drivers/usb/gadget/composite.c
    +++ b/drivers/usb/gadget/composite.c
    @@ -279,7 +279,7 @@ int usb_function_deactivate(struct usb_function *function)
    spin_lock_irqsave(&cdev->lock, flags);

    if (cdev->deactivations == 0)
    - status = usb_gadget_disconnect(cdev->gadget);
    + status = usb_gadget_deactivate(cdev->gadget);
    if (status == 0)
    cdev->deactivations++;

    @@ -311,7 +311,7 @@ int usb_function_activate(struct usb_function *function)
    else {
    cdev->deactivations--;
    if (cdev->deactivations == 0)
    - status = usb_gadget_connect(cdev->gadget);
    + status = usb_gadget_activate(cdev->gadget);
    }

    spin_unlock_irqrestore(&cdev->lock, flags);
    --
    1.9.1


    \
     
     \ /
      Last update: 2015-05-04 15:21    [W:6.426 / U:0.036 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site