lkml.org 
[lkml]   [2015]   [May]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 3.2 010/221] axonram: Fix bug in direct_access
    3.2.69-rc1 review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Matthew Wilcox <matthew.r.wilcox@intel.com>

    commit 91117a20245b59f70b563523edbf998a62fc6383 upstream.

    The 'pfn' returned by axonram was completely bogus, and has been since
    2008.

    Signed-off-by: Matthew Wilcox <matthew.r.wilcox@intel.com>
    Reviewed-by: Jan Kara <jack@suse.cz>
    Reviewed-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
    Signed-off-by: Jens Axboe <axboe@fb.com>
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    arch/powerpc/sysdev/axonram.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/arch/powerpc/sysdev/axonram.c
    +++ b/arch/powerpc/sysdev/axonram.c
    @@ -156,7 +156,7 @@ axon_ram_direct_access(struct block_devi
    }

    *kaddr = (void *)(bank->ph_addr + offset);
    - *pfn = virt_to_phys(kaddr) >> PAGE_SHIFT;
    + *pfn = virt_to_phys(*kaddr) >> PAGE_SHIFT;

    return 0;
    }


    \
     
     \ /
      Last update: 2015-05-05 04:21    [W:4.121 / U:0.688 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site