Messages in this thread | | | Date | Sat, 30 May 2015 13:45:32 +0200 | From | Heiko Carstens <> | Subject | Re: [PATCH V2] s390/sclp: pass timeout as HZ independent value |
| |
On Fri, May 29, 2015 at 04:50:55PM +0200, Nicholas Mc Guire wrote: > schedule_timeout takes a timeout in jiffies but the code currently is > passing in a constant SDIAS_SLEEP_TICKS, as this is otherwise unused > it is replaced by 500ms as recommended by Michael Holzheu > <holzheu@linux.vnet.ibm.com> and converted with msecs_to_jiffies(); > As SDIAS_SLEEP_TICKS was only used in this one location it is dropped. > > Patch was compile tested with (s390) defconfig + > CONFIG_MARCH_Z10=y, (implies CONFIG_CRASH_DUMP=y) > > Patch is against 4.1-rc5 (localversion-next is -next-20150529) > > Link: http://lkml.org/lkml/2015/5/29/235 > Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org> > --- > > V2: timeout clarified by Heiko Carstens <heiko.carstens@de.ibm.com> and > set to 500ms (HZ/2). And thanks for the test-config hints. > > drivers/s390/char/sclp_sdias.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-)
Applied, thanks!
| |