Messages in this thread | | | From | Arnd Bergmann <> | Subject | Re: [PATCH v2 2/4] devm: fix ioremap_cache() usage | Date | Sat, 30 May 2015 22:52:19 +0200 |
| |
On Saturday 30 May 2015, Dan Williams wrote: > @@ -154,7 +148,7 @@ void __iomem *devm_ioremap_resource(struct device *dev, struct resource *res) > } > > if (res->flags & IORESOURCE_CACHEABLE) > - dest_ptr = devm_ioremap(dev, res->start, size); > + dest_ptr = devm_ioremap_cache(dev, res->start, size); > else > dest_ptr = devm_ioremap_nocache(dev, res->start, size);
I think the existing uses of IORESOURCE_CACHEABLE are mostly bugs, so changing the behavior here may cause more problems than it solves.
Arnd
| |