lkml.org 
[lkml]   [2015]   [May]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v3 5/6] Watchdog: introduce ARM SBSA watchdog driver
    On 05/29/2015 08:46 AM, Timur Tabi wrote:
    > On 05/29/2015 09:32 AM, Fu Wei wrote:
    >> It is a SPI, every CPU can get it,
    >> But maybe I miss something, but please let me know if other CPU can
    >> not get the interrupt.
    >
    > There's only one watchdog device, so there's only one interrupt. I don't know which CPU will get the interrupt, but the watchdog is not a per-CPU device.
    >
    Plus, that one interrupt is not shared, and the driver returns
    IRQ_HANDLED even if the bit is not set. So _something_ is definitely
    wrong. Either the interrupt is shared, then it needs to be requested
    as shared and the handler should only return IRQ_HANDLED if it actually
    handles the interrupt. Or it is not shared and the handler should always
    handle it.

    Guenter



    \
     
     \ /
      Last update: 2015-05-30 01:01    [W:2.630 / U:1.408 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site